[Fix] use Eip2718Error, add docs on different encodings #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
added
bug
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
mattsse
approved these changes
Jun 11, 2024
Comment on lines
+216
to
+217
| /// The network encoding is the RLP encoding of the eip2718-encoded | ||
| /// envelope. |
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* fix: use 2718 error * nit: remove rlp reference * doc: more of em * Update crates/eips/src/eip2718.rs Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #283 and more!
Motivation
Turns out we weren't even using the 2718 error type.
Solution
Change Decodable2718 to use the error type.
Add docs about network encoding vs 2718 encoding
remove erroneous references to RLP in 2718 docs
PR Checklist