feat: support web3_sha3 provider function #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanGan21
changed the title
PanGan21
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
reviewed
Jun 30, 2024
mattsse
requested changes
Jun 30, 2024
DaniPopes
reviewed
Jun 30, 2024
mattsse
approved these changes
Jul 1, 2024
mattsse
changed the title
DaniPopes
approved these changes
Jul 1, 2024
17 tasks
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: add web3 client version method for web3 namespace * feat: add web3_sha3 method * feat: add unit tests * fix: use anvil instead of geth for tests * fix: use bytes slice in web3_sha3 * refactor: move sha3 to main trait and remove separate web3 api namespace * fix: format * fmt * fix: remove log * chore: nits --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the web3 namespace to the json-rpc methods. Related to #926
Motivation
Solution
PR Checklist