From f9d5815f5614f663e4bdecd4f11aada409513344 Mon Sep 17 00:00:00 2001 From: Yash Atreya <44857776+yash-atreya@users.noreply.github.com> Date: Fri, 15 Mar 2024 12:32:19 -0400 Subject: [PATCH 1/4] add: `new` method to iniliaze IpcConnect --- crates/transport-ipc/src/connect.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/crates/transport-ipc/src/connect.rs b/crates/transport-ipc/src/connect.rs index 1371aa64dcf..eb26a42d43b 100644 --- a/crates/transport-ipc/src/connect.rs +++ b/crates/transport-ipc/src/connect.rs @@ -9,6 +9,16 @@ pub struct IpcConnect { inner: T, } +impl IpcConnect { + /// Create a new IPC connection object for any type T that can be converted into IpcConnect. + pub fn new(inner: T) -> Self + where + Self: From, + { + IpcConnect::from(inner) + } +} + macro_rules! impl_connect { ($target:ty) => { impl From<$target> for IpcConnect<$target> { From 7b2a3eb53f94b60ec27e2b3e0f57ee54efebab62 Mon Sep 17 00:00:00 2001 From: Yash Atreya <44857776+yash-atreya@users.noreply.github.com> Date: Fri, 15 Mar 2024 13:14:53 -0400 Subject: [PATCH 2/4] add pubsub trait bound --- crates/transport-ipc/src/connect.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/transport-ipc/src/connect.rs b/crates/transport-ipc/src/connect.rs index eb26a42d43b..461af4c7318 100644 --- a/crates/transport-ipc/src/connect.rs +++ b/crates/transport-ipc/src/connect.rs @@ -13,7 +13,7 @@ impl IpcConnect { /// Create a new IPC connection object for any type T that can be converted into IpcConnect. pub fn new(inner: T) -> Self where - Self: From, + Self: alloy_pubsub::PubSubConnect + From, { IpcConnect::from(inner) } From 39a3f48075f63ab896a4e6593d584732344a97f7 Mon Sep 17 00:00:00 2001 From: Yash Atreya <44857776+yash-atreya@users.noreply.github.com> Date: Fri, 15 Mar 2024 13:27:37 -0400 Subject: [PATCH 3/4] fix: docs ci --- crates/transport-ipc/src/connect.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/transport-ipc/src/connect.rs b/crates/transport-ipc/src/connect.rs index 461af4c7318..cb4916e6f5e 100644 --- a/crates/transport-ipc/src/connect.rs +++ b/crates/transport-ipc/src/connect.rs @@ -10,7 +10,8 @@ pub struct IpcConnect { } impl IpcConnect { - /// Create a new IPC connection object for any type T that can be converted into IpcConnect. + /// Create a new IPC connection object for any type T that can be converted into + /// `IpcConnect`. pub fn new(inner: T) -> Self where Self: alloy_pubsub::PubSubConnect + From, From ef3ead2513db214883fefcae0b43fc141351564d Mon Sep 17 00:00:00 2001 From: Yash Atreya <44857776+yash-atreya@users.noreply.github.com> Date: Fri, 15 Mar 2024 14:13:00 -0400 Subject: [PATCH 4/4] nits --- crates/transport-ipc/src/connect.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/transport-ipc/src/connect.rs b/crates/transport-ipc/src/connect.rs index cb4916e6f5e..6857820e34b 100644 --- a/crates/transport-ipc/src/connect.rs +++ b/crates/transport-ipc/src/connect.rs @@ -12,11 +12,11 @@ pub struct IpcConnect { impl IpcConnect { /// Create a new IPC connection object for any type T that can be converted into /// `IpcConnect`. - pub fn new(inner: T) -> Self + pub const fn new(inner: T) -> Self where - Self: alloy_pubsub::PubSubConnect + From, + Self: alloy_pubsub::PubSubConnect, { - IpcConnect::from(inner) + Self { inner } } }