Updates Mantle + Mantle Testnet configuration #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jul 30, 2024
|
we also need to update the test runner to 1.70 |
DaniPopes
reviewed
Jul 30, 2024
| MantleTestnet = 5001, | ||
| #[strum(to_string = "mantle-sepolia")] | ||
| #[cfg_attr(feature = "serde", serde(alias = "mantle-sepolia"))] | ||
| MantleSepolia = 5003, |
There was a problem hiding this comment.
please keep the old variant name and add aliases to avoid breaking changes
There was a problem hiding this comment.
It is a bit confusing because the Mantle Testnet was 5001 and the new Mantle Sepolia Testnet is 5003 see: https://chainlist.org/?search=mantle&testnets=true
Decided to add back MantleTestnet for backwards compatibility with Mantle Sepolia Testnet being distinct
Mantle Testnet is deprecated however
mattsse
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Mantleto be EIP-1559 compliant, updateMantleTestnet(deprecated) toMantleSepolia, see: https://www.mantle.xyz/blog/announcements/mantle-completes-mainnet-v2-tectonic-upgrade + https://www.mantle.xyz/blog/announcements/mantle-v2-sepolia-testnet-now-liveRelated: foundry-rs/foundry#8553 (comment)
Also closes: gakonst/ethers-rs#2803