Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Assembly Accelerated Keccak #414

Closed
gakonst opened this issue Nov 17, 2023 · 1 comment · Fixed by #466
Closed

[Feature] Assembly Accelerated Keccak #414

gakonst opened this issue Nov 17, 2023 · 1 comment · Fixed by #466
Labels
enhancement New feature or request

Comments

@gakonst
Copy link
Member

gakonst commented Nov 17, 2023

Component

primitives

Describe the feature you would like

Currently we use tiny_keccak for our keccak256 function:

pub fn keccak256<T: AsRef<[u8]>>(bytes: T) -> FixedBytes<32> {
.

We have a native-keccak feature for usage in Arbitrum.

We'd like to provide Keccak with assembly & accelerated instructions where possible. See @DaniPopes example usage:
https://github.com/DaniPopes/bench-keccak256/blob/127641b353c8d03fe40ca0918bee6a9991d45174/src/lib.rs#L4-L45

This yields a 15-20% improvement on keccak-asm.

Additional context

No response

@gakonst gakonst added the enhancement New feature or request label Nov 17, 2023
@Arindam2407
Copy link

I can take up this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants