Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OP fields missing from op_alloy_rpc_types::OpTransactionReceipt #54

Closed
2 tasks
emhane opened this issue Aug 28, 2024 · 2 comments · Fixed by #62
Closed
2 tasks

[Bug] OP fields missing from op_alloy_rpc_types::OpTransactionReceipt #54

emhane opened this issue Aug 28, 2024 · 2 comments · Fixed by #62
Labels
C-bug Category: Something isn't working

Comments

@emhane
Copy link
Collaborator

emhane commented Aug 28, 2024

Component

consensus, eips, genesis, rpc

Describe the feature you would like

To add OP fields, either make new variants of OpReceiptEnvelope, e.g. OpReceiptEnvelope::Ecotone type OpEcotoneReceipt for blob fields, or re-define type OpTransactionReceipt. Implement decoding of OpTransactionReceipt with OP fields. Adding directly to OpTransactionReceipt may make sense for some op fields, for others not.

Ref https://github.com/ethereum-optimism/op-geth/blob/f2e69450c6eec9c35d56af91389a1c47737206ca/core/types/receipt.go#L87-L87

Additional context

Deposit tx envelope has fields for deposit nonce, and so does OptimismTransactionReceiptFields, so OptimismTransactionReceiptFields cannot be added to OpTransactionReceipt as is.

@emhane
Copy link
Collaborator Author

emhane commented Aug 28, 2024

cannot make new variant OpReceiptEnvelope::Ecotone due to same tx type as eip4844 (ty = 3). hence, must change type wrapped in OpReceiptEnvelope::Eip4844, but leave fields as option to allow for eip4844 and ecotone receipts for tx type 3.

OpTxType::Eip4844 => Ok(Self::Eip4844(Decodable::decode(buf)?)),

@refcell refcell removed the debt label Aug 28, 2024
@emhane emhane added the C-bug Category: Something isn't working label Aug 29, 2024
@emhane
Copy link
Collaborator Author

emhane commented Aug 29, 2024

good call @refcell

@emhane emhane changed the title [Feature] OP fields missing from op_alloy_rpc_types::OpTransactionReceipt [Bug] OP fields missing from op_alloy_rpc_types::OpTransactionReceipt Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants