-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closeout punchlist #7
Comments
For indicating current category, I made a class called 'active' -- not sure on placement in cddl-navigation.js, but should be something like: $(".circle-nav-item").click(() => { |
Thanks @nofurtherinformation - that'll be handled best in the template. I'll take a look at lunch. |
Thanks @allthesignals! Another question -- looking at text in the center seems to be a good option, but will overlap where the answer labels are -- can we modify the CSS that governs where the labels are to avoid that area? If you point me in the right direction I can take a crack at it. |
Do you mean the question prompts? Yes the CSS can be found here. Those labels styles are probably defined at the bottom somewhere. The response cluster labels positioning isn't going to be as flexible, though. |
The question prompt is easy, but the label locations seem to generate inline css, I think here. See screenshot - response labels overlap question prompt if in the middle: |
Here's an example the inline CSS I'm trying to track down:
|
Yes, they're inline because they are generated from a D3 force-direct graph... we can't really do a whole lot with their positions unless you look at the What are you trying to do? Does the question prompt need to be in the middle? |
Got it. Yes, we're looking at alternate typography to make the questions stand out more -- will post some CSS to the style doc in a few. |
@nofurtherinformation what if we go drastic and reverse figure ground for the questions? I'll push my suggestions up as a PR. You'll see I also added
Just food for thought--I don't feel super strongly about this either way. |
Hi folks, I've updated the punchlist to include priorities from our meeting |
Just pushed up a change on experiment branch that tightens up the radius of the clusters |
@Siqister This is perfect! Seeing the close X, too, which is great. |
Referencing latest bug list:
https://docs.google.com/spreadsheets/d/1XvzZZ5a-ij2H-2D1rXOrl9Tx3hD3uIsv17oVGCUDG-k/edit?usp=gmail#gid=0
Design / UI / UX
Frontend
Deployment
The text was updated successfully, but these errors were encountered: