Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeFormatters do not seem to work #377

Closed
1 of 3 tasks
kemsky opened this issue Sep 2, 2023 · 1 comment · Fixed by #395
Closed
1 of 3 tasks

TypeFormatters do not seem to work #377

kemsky opened this issue Sep 2, 2023 · 1 comment · Fixed by #395
Assignees
@delatrie
Labels
bug

Comments

@kemsky
Copy link

kemsky commented Sep 2, 2023

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support request here, see note at the top of this template.

Instead of formatted value I get class name. Debugger shows AllureStepAspect and AllureStepParameterHelper do not have any code to format params with type formatter.

Please tell us about your environment:

  • Allure version: 2.9.5-preview-1
  • Test framework: nunit@3.13.3
delatrie added a commit that referenced this issue Oct 12, 2023
@delatrie
Apply custom formatters to step title and parameters
ec8b66b 
Now step title interpolation and step parameter value conversion uses the same
algorithm as test parameter conversions.

Fixes #377
@delatrie delatrie mentioned this issue Oct 12, 2023
Merged
2 tasks
@delatrie delatrie linked a pull request Oct 12, 2023 that will close this issue
Fix identification properties and parameter formatting #395
Merged
2 tasks
@delatrie delatrie self-assigned this Oct 12, 2023
@delatrie delatrie added the bug label Oct 12, 2023
neparij pushed a commit that referenced this issue Oct 12, 2023
@delatrie
Fix identification properties and parameter formatting (#395)
72890a3 
* Bump NUnit for test and example projects

* Add json schemas for allureConfig and testplan

* Fix schema for allure-xunit and allure-specflow config

* Add legacy naming switch to config

* Update schema links to current branch

* Add schema links update task to release workflow

* Implement UUID and method-based fullName algorithms

* Common fns to calculate testCaseId, historyId and parameter value

* Add docstrings to new id-related functions

* Add function to create fullName from class

* Fix allureConfig item type for allure-nunit examples

* Add missing setter for UseLegacyIds config property

* Add framework label factory

* Fix uuid, fullName, historyId, testCaseId for allure-nunit

UseLegacyIds option is honored.

Additionally:
  - fix uuid for containers
  - fix missing historyId for ignored tests. Same id rules apply as for non-ignored tests (fixes #345)
  - add NUnit 3 framework label to test results
  - remove suites from AllureDisplayIgnored (now suites can be applied directly)
  - fix parameter names for parametrized test methods

* Apply custom formatters to step title and parameters

Now step title interpolation and step parameter value conversion uses the same
algorithm as test parameter conversions.

Fixes #377

* Add language label to commons and NUnit

* Fix uuid, fullName, historyId, testCaseId for allure-xunit

Legacy identifiers switch is honored.

Additionally:
  - Add framework and language labels to allure-xunit test results
  - Fix test parameters formatting. Custom type formatters are also used now

* Add no-formatters step helper overloads back to public API

* Revert autoedit this removal from StepFunctionTests.cs

* Fix uuid, fullName, historyId, testCaseId for allure-specflow

Legacy ids switch is honored.

Implements #387

* Implement requested changes
@delatrie
Copy link
Contributor

Hi, @kemsky ! That should be fixed in the new 2.10.0 release. Check it out!
If the issue persists, please, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delatrie delatrie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix identification properties and parameter formatting allure-framework/allure-csharp
2 participants
@kemsky @delatrie