Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allure-selenide doesn't work correct with Selenide 5.x multi-browser function in some cases #379

Closed
vinogradoff opened this issue Jul 24, 2019 · 2 comments

Comments

@vinogradoff
Copy link
Contributor

allure/allure-selenide 2.12.1

Beginning with Selenide 5.x WebDriverRunner.getWebDriver() can delivery the wrong webdriver depending on configuration, if multiple browser are used in a single test.

Also screenshot logger crashes trying to make a screenshot when open (=WebDriver.get(url)) function fails to open the browser session correctly.

Reproducible example for the second case:
https://github.com/vinogradoff/sandbox-selenide/blob/master/src/test/java/org/selenide/allure/SimpleTest.java

@vinogradoff
Copy link
Contributor Author

Methods to be fixed:

private static Optional<byte[]> getScreenshotBytes() {

private static Optional<byte[]> getPageSourceBytes() {

@asolntsev
Copy link
Contributor

@baev What about a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants