fix: Write in place with exiftool #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes allusion-app#623 This fixes issues with the way renamed files are detected from inode numbers, which would become desynced whenever exiftool was used. Any files that had their metadata edited would not be correctly detected as moved, and the web clipper would occasionally overwrite existing database entries, mistaking them for moved files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623
This fixes issues with the way renamed files are detected from inode numbers, which would become desynced whenever exiftool was used. Any files that had their metadata edited would not be correctly detected as moved, and the web clipper would occasionally overwrite existing database entries, mistaking them for moved files.
Note: using inode numbers for detecting renames is still a potential source of errors because any external tool that overwrites files in this way will also similarly desync the database. This just fixes Allusion desyncing the database with its own operations.