Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a day not at 00:00 #148

Closed
ouuan opened this issue Feb 5, 2022 · 8 comments · Fixed by #291 or #300
Closed

Start a day not at 00:00 #148

ouuan opened this issue Feb 5, 2022 · 8 comments · Fixed by #291 or #300
Labels

Comments

@ouuan
Copy link

ouuan commented Feb 5, 2022

I often go to sleep after 00:00, so it would be nice to be able to configure the start of a day. I mainly want it when focusing "today" ("snap to now"). It could also be used in reports grouped by date.

@almarklein almarklein added the Idea label Feb 5, 2022
@almarklein
Copy link
Owner

Interesting idea. I sometimes have the same problem, but I then either let it be, or drag the record backwards so its fully in the previous day :)

I think it should be possible to configure the day's start time, but indeed then it should also hold up for the report.

This was referenced Feb 7, 2022
@lgaudreau
Copy link

Would be great to set starting and ending hours

@almarklein
Copy link
Owner

I was initially positive about this idea, but now that I looked into it, I decide against it. The main reason is that the definition of when a day starts is pretty clear (in contrast to when a new weeks starts #157). This means that some things are technically quite challenging, resulting in more complex code (e.g. in the dt.floor()), which also means higher risk on bugs, but I also think it may simply be confusing, e.g. imagine this timeline 🤔:

In summary, although I understand the use-case (and share it), I don't think its a good idea to allow changing day boundaries. As a workaround, just drag your late-night records back into the previous day. Or - speaking for myself here - go to bed on time, it'll do you good ❤️

@ouuan
Copy link
Author

ouuan commented Nov 21, 2022

I think it will be very helpful even if this only affects the range of snapping to "today".

@almarklein
Copy link
Owner

Mmm. So the only place where we apply the offset is when snapping to today. I think this could work ...

@almarklein
Copy link
Owner

@ouuan thanks for the suggestion. It's a pragmatic solution that I think covers the most pain points, while not having the downsides that I mentioned earlier. Done in #291

@almarklein
Copy link
Owner

New release with this change is now available. Let's see how this works out! 🚀

@almarklein almarklein reopened this Nov 26, 2022
@almarklein
Copy link
Owner

Re-opening because I found an annoyance with the current implementation. In #291 clicking "today" (or pressing "D") toggles between the actual day and the offset. However, if you're in a completely different view, it first moved to the actual day, while I think it'd be more natural to go to the day with offset instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants