Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width layout #162

Closed
boehs opened this issue Feb 13, 2022 · 8 comments · Fixed by #209
Closed

Full width layout #162

boehs opened this issue Feb 13, 2022 · 8 comments · Fixed by #209
Labels

Comments

@boehs
Copy link

boehs commented Feb 13, 2022

Currently max width of canvas is 1024px, would be nice if I could opt to have it be the full screen width. I tried to figure this out in code but no luck :(

@almarklein
Copy link
Owner

Worth looking into, but I'm not sure if full width would make the app more useful/pretty. That said, being able to make it wider than it is now seems reasonable.

@GitHofi
Copy link

GitHofi commented Feb 14, 2022

That, I would also like, especially if more of the log text would then be readable.
Currently I can only see 2 tags and hardly anything of the text
2022_0214_0948_01
.

@almarklein almarklein mentioned this issue Feb 17, 2022
@almarklein
Copy link
Owner

Closed by #171

@eldelacajita
Copy link

eldelacajita commented Mar 18, 2022

Hi, Almar. This is a welcome improvement!

I was actually hoping for a completely no-margin option. This is my use case:

I use TimeTagger as a standalone web app (using Web browser on Gnome, Linux). When the window is small and there are no margins, it looks awesome:

imagen

But when I snap the window to the full width of my screen (in this case 1200 px, because it's a vertical monitor), the margin appears and it looks less like an app and more like a web inside a frame. And it doesn't take advantage of the extra width for displaying content.

imagen

Also removing the lower margin would be great, but I can live with that. I mean, I can live with both, actually 😄 It's just a small visual and functional improvement.

@almarklein
Copy link
Owner

Ok, I see your point. I'm starting to think that this needs to be configurable, preferably using a sash/button near the edge of the screen.

I don't understand why there is a margin at the bottom. That should not be there, and I cannot reproduce it (tried installing as an app in Chrome, but I see no margin at the bottom.)

@almarklein almarklein reopened this Mar 18, 2022
@almarklein
Copy link
Owner

I don't understand why there is a margin at the bottom.

This looks like #194, and should probably be fixed with #198.

@almarklein
Copy link
Owner

Released and deployed!

@eldelacajita
Copy link

Yay! Thanks a lot, I'm loving it 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants