Broken comparison function in compute_suggestion

[ghost]

This comparison function is broken.

According to it, these two statements are true at the same time:

• (11, 0.0) < (14, 0.0)
• (14, 0.0) < (11, 0.0)

The vector will be sorted in a totally unreliable order.
See this issue and the fix suggested by @bluss: rust-lang/rust#38685

[alopatindev]

Thank you for finding this! Fixed.

[ghost]

Glad this got fixed! Just a quick note - you can simplify compare_channels_load a bit... :)

fn compare_channels_load(a: &ChannelLoad, b: &ChannelLoad) -> cmp::Ordering {
    (&a.1, &a.0).partial_cmp(&(&b.1, &b.0)).unwrap()
}