Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAS-1576 Add config for local running #330

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

jonathan-owens-gds
Copy link
Contributor

@jonathan-owens-gds jonathan-owens-gds commented Nov 6, 2023

The HOST variable is used to distinguish between running locally and on the hosted infrastructure (i.e. AWS). This variable can therefore take one of the following values:

HOST = [ local | hosted | test ]

"local" indicates that the service will be configured for running on a local machine. "hosted" is intended for use when the service is running on the AWS-hosted infrastructure. "test" provides a special set of configuration values that are used by the unit, integration and functional tests.

The environment variable ENVIRONMENT is used to tell the service which set of config values to take up, and can be set to one of the following values:

ENVIRONMENT = [ local | development | preview | staging | production ]

A value of "local" indicates that the service will be running on the development machine. A value corresponding to any of the others in the above set maps directly to the name of the environment hosted in AWS.

The development environment hosted on AWS will now configure the above variables as follows:
HOST=hosted & ENVIRONMENT=development


🚨⚠️ This will be deployed automatically all the way to production when you click merge ⚠️🚨

See docs/deploying.md for notes and caveats about this app.

app/__init__.py Outdated Show resolved Hide resolved
app/config.py Show resolved Hide resolved
@Adam-C-Mitchell
Copy link
Contributor

Otherwise this looks good to me, some good changes that definitely make it easier to understand configs across the infrastructure I think.

Copy link
Collaborator

@simon-sorrell-gds-alerts simon-sorrell-gds-alerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by architects and service management this morning, and the go ahead was given to roll out, pausing at production to make sure no adverse affects in preview/staging first.

@jonathan-owens-gds jonathan-owens-gds merged commit 36f412f into main Nov 30, 2023
1 check passed
@jonathan-owens-gds jonathan-owens-gds deleted the EAS-1576-fix-dev-config branch November 30, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants