Skip to content

Commit

Permalink
Remove deprecated SCSS variables
Browse files Browse the repository at this point in the history
- $govuk-new-link-styles is now set to true by default
- The other SCSS variables are deprecated from v5 of govuk-frontend
  • Loading branch information
jon-kirwan authored and MartinJJones committed Jul 5, 2024
1 parent 719f082 commit 1a4bda2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
4 changes: 0 additions & 4 deletions app/assets/stylesheets/application.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
// The main application stylesheet
$govuk-compatibility-govuktemplate: false;
$govuk-typography-use-rem: false;
$govuk-use-legacy-palette: false;
$govuk-new-link-styles: true;

// This flag stops the font from being included in this application's
// stylesheet - the font is being served by Static across all of GOV.UK, so is
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}

.app-c-contents-list-with-body__link-wrapper.sticky-element--stuck-to-window {
background-color: govuk-colour("light-grey", $legacy: "grey-3");
background-color: govuk-colour("light-grey");
bottom: -1px; // 'Fix' for anomalous 1px margin which sporadically appears below this element.
left: 0;
margin: 0;
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/helpers/_parts.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
margin-bottom: 0;
}

border-bottom: 1px solid govuk-colour("mid-grey", $legacy: "grey-2");
border-bottom: 1px solid govuk-colour("mid-grey");
}

.part-navigation {
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/views/_manual.scss
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
list-style: none;

&:hover {
background-color: govuk-colour("light-grey", $legacy: "grey-4");
background-color: govuk-colour("light-grey");
}

&:last-child {
Expand Down

0 comments on commit 1a4bda2

Please sign in to comment.