Upgrade to govuk frontend 5.1 #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
1d4042a to
7732439
Compare
Closed
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
7732439 to
b0f20a6
Compare
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
b0f20a6 to
abf2cde
Compare
MartinJJones
changed the title
andysellick
approved these changes
Jul 10, 2024
|
@MartinJJones one failing test still, on the label text thing |
Thanks Andy, this is expected, the test will pass once the version of the gem is bumped to the v5 release as part of this PR. Happy to wait on this and get approval on release day once the test is passing. |
MartinJJones
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
abf2cde to
77d49b5
Compare
To prevent browsers evaluating JS that isn't supported, components that contain code from govuk-frontend have been moved to a separate file `es6-components.js` which is included in `application.html.erb` as a script tag with `type="module"`.
- $govuk-new-link-styles is now set to true by default - The other SCSS variables are deprecated from v5 of govuk-frontend
hannako
force-pushed
the
upgrade-to-govuk-frontend-5.1
branch
from
77d49b5 to
a64367e
Compare
hannako
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
es6-components.jsfileWhy
Move components that rely on govuk-frontend modules to seperate
es6-components.jsfileIn the event that a browser below the target for
govuk-frontendloads a page with JS on it, attempting to parse the JS fromgovuk-frontendwill cause an error. To avoid this from happening, JS that containsgovuk-frontendJS has been moved to seperate file which will be loaded in a script tag withtype="module". This will prevent the JS from being parsed and so prevent the errorRemove Sass variables
$legacyattribute ingovuk-colourhas been deprecated and using it will have no effect (other than generating warnings on pre-compilation)$govuk-compatibility-govuktemplate$govuk-use-legacy-palette$govuk-typography-use-rem$govuk-new-link-stylesis now set totrueby default, so it does not need to be setUpdate test for phase banner text
In govuk-frontend v5 the phase banner text is no longer uppercase, now only the first letter of a word is capitalised and the rest of the content lowercase
Trello
The intention is for the PR to include the upgrade to the version of the publishing_components_gem as well, once released. This will also fix the failing test.
Follow these steps if you are doing a Rails upgrade.