Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component examples don't load IE8 stylesheet #2612

Closed
chris-gds opened this issue Feb 3, 2022 · 2 comments
Closed

Component examples don't load IE8 stylesheet #2612

chris-gds opened this issue Feb 3, 2022 · 2 comments
Labels
accordion 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@chris-gds
Copy link

chris-gds commented Feb 3, 2022

Description of the issue

While testing v4 on GOVUK noticed the fallback icon was missing
(not an issue on GOVUK support is IE11+)

Steps to reproduce the issue

Visit https://govuk-design-system-preview.netlify.app/ (In Browserstack > IE8)

Actual vs expected behaviour

https://github.com/alphagov/govuk-frontend/blob/main/package/govuk/components/accordion/_index.scss#L175

image

vs

Expected

image

Environment (where applicable)

  • Operating system: Windows
  • Browser: Internet Explorer
  • Browser version: 8
  • GOV.UK Frontend Version: 4

Low Priority

@chris-gds chris-gds added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team labels Feb 3, 2022
@owenatgov owenatgov removed the awaiting triage Needs triaging by team label Mar 30, 2022
@querkmachine
Copy link
Member

querkmachine commented Feb 20, 2023

Having given this a quick looksee, this appears to be an issue specific to the Design System website's implementation of the accordion. The version in the Frontend review app displays as expected.

Specifically, the layout used for this example doesn't load the IE8-specific stylesheet, so the fallback iconography we include for IE8 isn't being loaded or used.

To that effect, I'm going to alter this issue and move it over to the Design System repository.

@querkmachine querkmachine transferred this issue from alphagov/govuk-frontend Feb 20, 2023
@querkmachine querkmachine changed the title IE8 fallback icon - accordion Component examples don't load IE8 stylesheet Feb 20, 2023
@36degrees
Copy link
Contributor

Closing as the Design System website no longer supports IE8.

@36degrees 36degrees closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accordion 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

4 participants