Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that GOV.UK Frontend meets WCAG 2.1 #677

Closed
31 tasks done
timpaul opened this issue Jan 9, 2019 · 3 comments
Closed
31 tasks done

Make sure that GOV.UK Frontend meets WCAG 2.1 #677

timpaul opened this issue Jan 9, 2019 · 3 comments
Labels
epic Epics are used in planning project boards to group related stories

Comments

@timpaul
Copy link
Contributor

timpaul commented Jan 9, 2019

What

Make sure that the Design System, and everything in it meets at least level AA of the WCAG 2.1 guidelines.

Why

All services that went live after 23 September 2018 must meet WCAG2.1 AA by 23 September 2019. Older services must meet the same standard by 23 September 2020. We need to support service teams by ensuring that everything in the GOV.UK Design System meets this standard.

1. Address known accessibility issues

Must

Should

Better align custom tab logic with tab component
Publish accessibility principles, criteria and guidance
Investigate potential issues with conditional reveals (#979, #935, #989)

Could

Content below buttons on start pages
Investigate whether we should specify 'aria-invalid' on form inputs that have errors
Investigate adding iOS dynamic type support

2. Modify the components and test

3. External audit of the Design System

4. Prepare for publishing

See this epic - Release Frontend 3.0

Notes

See 30th April team catch up notes

@timpaul timpaul added the epic Epics are used in planning project boards to group related stories label Jan 9, 2019
@timpaul timpaul changed the title Make sure the Design System meets the latest accessibility standards Address known WCAG 2.1 non-compliance issues Jan 11, 2019
@timpaul timpaul changed the title Address known WCAG 2.1 non-compliance issues Make sure that the Design System meets WCAG 2.1 Jan 24, 2019
@alex-page
Copy link

Oh yeah!!! We should collaborate ASAP. The whole reason our Design System exists is to meet WCAG 2.1. There is no benefit working seperately on these problems.

@alex-page
Copy link

alex-page commented Jan 31, 2019

Hey friends I noticed you have a lot of problems with meeting colour contrast and you are using sass.

Feel free to use our open source package sass a11ycolor to find the closest accessible color.

We use it to generate our custom colour schemes, you can see it working by going to our customise page here and entering in the same colour value. It makes some of the reds darker to make sure the contrast passes.

We use it in other ways like generating muted colours, we mix the background and foreground colours together then get the closest accessible colour of the mixed colour on the background. Have a look here:
https://github.com/govau/design-system-components/blob/da652cbab7ee3417812676314d1e1e5418f89059/packages/core/src/sass/_globals.scss#L807-L819

@kellylee-gds kellylee-gds mentioned this issue May 23, 2019
34 tasks
@NickColley
Copy link
Contributor

I have raised all the issues for the Design System website which brings us to 34 total GitHub issues which matches the DAC issue numbers that go to 33 (plus Ollie's in person issue).

https://github.com/issues?q=label%3A%22audit%3A+may-2019%22+user%3Aalphagov

@timpaul timpaul changed the title Make sure that the Design System meets WCAG 2.1 Make sure that GOV.UK Frontend meets WCAG 2.1 Jul 15, 2019
@timpaul timpaul closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories
Projects
None yet
Development

No branches or pull requests

3 participants