Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IE8-10 scripts, styles, comments, polyfills etc #2642

Merged
merged 7 commits into from
Mar 13, 2023
Merged

Remove IE8-10 scripts, styles, comments, polyfills etc #2642

merged 7 commits into from
Mar 13, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Feb 27, 2023 •
edited
Loading

Also whilst I've been spiking "cut the mustard" using the Design System:

I found it handy to remove all the IE8-10 bits that got in the way, which also closes:

@colinrotherham colinrotherham added dependencies Pull requests that update a dependency file consistency labels Feb 27, 2023
@colinrotherham colinrotherham self-assigned this Feb 27, 2023
@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited
Loading

✅ You can preview this change here:

Name Link
🔨 Latest commit bb9b72a
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/6406533adb740a00070a5c14
😎 Deploy Preview https://deploy-preview-2642--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@colinrotherham
Copy link
Contributor Author

colinrotherham commented Feb 27, 2023 •
edited
Loading

Note that some modernizr.config feature detects remain to cover IE9 (although IE10-11 can use -ms- prefixes)

Update: I've removed Modernizr too since we're only supporting IE11 now

@colinrotherham colinrotherham mentioned this pull request Feb 27, 2023
Merged
@colinrotherham colinrotherham force-pushed the remove-support-ie8 branch 2 times, most recently from ec8a276 to 6987fda Compare March 1, 2023 11:51
@colinrotherham colinrotherham changed the title Remove IE8 scripts, styles, comments, polyfills etc Remove IE8-10 scripts, styles, comments, polyfills etc Mar 1, 2023
@colinrotherham colinrotherham force-pushed the add-support-mjs branch 2 times, most recently from c48bfc9 to d473882 Compare March 3, 2023 16:29
Base automatically changed from add-support-mjs to main March 6, 2023 13:09
romaricpascal
romaricpascal approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections after reviewing in dev catch-up, let's ship this! ⛵

@colinrotherham colinrotherham merged commit 78f1877 into main Mar 13, 2023
@colinrotherham colinrotherham deleted the remove-support-ie8 branch March 13, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaricpascal romaricpascal romaricpascal approved these changes

Assignees

@colinrotherham colinrotherham

Labels
consistency dependencies Pull requests that update a dependency file
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinrotherham @romaricpascal