Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if push Actions run on forked branches... #337

Closed
wants to merge 1 commit into from
Closed

Test if push Actions run on forked branches... #337

wants to merge 1 commit into from

Conversation

issyl0
Copy link
Contributor

@issyl0 issyl0 commented Apr 27, 2020

They don't[1], and push events don't work on the main repo if the branch is from a fork. So we'd be in the same situation as we currently are with Jenkins unless we have both pull_request and push, OR just pull_request and change our dev workflow to not rely so much on CI.

[1] -
Screenshot 2020-04-27 at 11 45 54

@issyl0 issyl0 closed this Apr 27, 2020
@issyl0 issyl0 deleted the test-push-actions-from-forks branch April 27, 2020 10:51
issyl0 added a commit that referenced this pull request Apr 27, 2020
- This matches our current thinking in
  alphagov/govuk-rfcs#123, given that [push
  events don't run on forked branches in the forked repo, or when
  they're made into PRs](#337).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant