Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid columns do not align with service name #1122

Closed
edwardhorsford opened this issue Jan 9, 2019 · 2 comments
Closed

Grid columns do not align with service name #1122

edwardhorsford opened this issue Jan 9, 2019 · 2 comments
Assignees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@edwardhorsford
Copy link
Contributor

I'm working on a service that makes use of a one third / two thirds column grid layout. The first column is filtering, and main content on the right.

At the moment the main content doesn't align with the service name - but it almost does. Enough that it looks like a bug / fault in the code. Would it be possible for these to align?

screenshot 2019-01-09 at 17 16 28

In other places the header aligns with the grids - such as the GOV.UK search box:
screenshot 2019-01-09 at 17 31 02

@NickColley
Copy link
Contributor

NickColley commented Jan 9, 2019

Hey Ed,

I've made a live example to poke here:

https://govuk-frontend-issue-1112.glitch.me/

Looks to be misaligned since the grid has gutters of 30px whereas the header does not, even though the percentages are consistent.

So if we did something like this I think we can get these to align...

@media (min-width: 48.0625em) {
  .govuk-header__logo,
  .govuk-header__content {
    box-sizing: border-box;
  }
  .govuk-header__logo {
    padding-right: 15px;
  }
  .govuk-header__content {
    padding-left: 15px;
  }
}

@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jan 9, 2019
@edwardhorsford
Copy link
Contributor Author

@NickColley thanks for looking at this. That sounds sensible.

A side effect is there's slightly less space for service name in the header - but on mobile they split on to two lines anyway so the impact should be minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
Development

No branches or pull requests

2 participants