Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header is misaligned in Internet Explorer 8 #1145

Closed
NickColley opened this issue Jan 16, 2019 · 1 comment · Fixed by #1147
Closed

Header is misaligned in Internet Explorer 8 #1145

NickColley opened this issue Jan 16, 2019 · 1 comment · Fixed by #1147
Assignees
@NickColley
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@NickColley
Copy link
Contributor

I'm not sure if this is a recent regression, but I found that the header doesnt render as I'd expect while working on the spacing (#1122)

screen shot 2019-01-16 at 17 29 27

On the GOV.UK Prototype Kit site there also seems to be misrendering of the header:

screen shot 2019-01-16 at 17 30 21

In internet explorer 9 there are no issues with either.
@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jan 16, 2019
@NickColley NickColley mentioned this issue Jan 16, 2019
Merged
1 task
@NickColley
Copy link
Contributor Author

Looks to be because the container does not have margin: auto, since those rules are in a media query (which are not supporting in IE8).

We could consider adding margin: auto to the header container, or potentially this is a wider issue for all containers: https://github.com/alphagov/govuk-frontend/blob/master/src/objects/_width-container.scss#L1

@NickColley NickColley mentioned this issue Jan 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickColley NickColley

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix container not being centered in IE8 alphagov/govuk-frontend
1 participant
@NickColley