-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen-readers may not 'announce' lists if 'list-style: none' is used #1471
Comments
This also applies to components such as breadcrumbs, error summary (links), footer, header (navigation links). |
Had a go with the CSS suggested improvements, the zero width suggestion creates an unwanted visual spacing, the postCSS SVG image suggestion creates a bullet that can be navigated to using voiceover when pressing I've had a look at adding the specific role attributes, I think this could be useful for the component templates but is probably not so pragmatic for the general lists as they don't tend to be templated. I think my main thinking aligns with Scott's and Adrian's here:
If we had evidence that this decision by VoiceOver was negatively impacting users I think we'd likely want to change things, but as is, this behaviour is consistent across all websites for VoiceOver users. Welcome others thoughts here. |
Interesting, thanks for raising this @glenpike. I agree with @NickColley that it would be good to see some evidence of this being a problem for users. I'd possibly be wary of changing something with no evidence when that behaviour will then be different to the rest of the web as that also has the potential for confusing users. |
Alright let's close this for now, but this is a really good thread if we need to pick it up again in the future thanks a bunch @glenpike. |
reopening as a related issue came up in our audit someone who tested this using a screen reader was confused. VoiceOver in Safari gives this output:
One of the key issues here I think is that sighted users can see a list - VoiceOver is not announcing a list or list members because of the issue discussed on this thread. If we add I think it would be worth adding |
Thanks for all your good work on the Design System, it's been really useful!
We've been using it on our website and recent testing with a screen-reader (VoiceOver in Safari) has shown up a possible issue with the basic govuk-list class.
Basically, if we use this style, the reader doesn't announce the list like it would do for the bulleted list.
This article sums it up quite well and gives a possible solution: https://www.scottohara.me/blog/2019/01/12/lists-and-safari.html
Is this something you would consider tweaking? Current workaround is to add role="list" to the
<ul>
The text was updated successfully, but these errors were encountered: