Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behaviour of null errorMessage attribute #1744

Closed
edwardhorsford opened this issue Feb 19, 2020 · 0 comments · Fixed by #1748
Closed

Document behaviour of null errorMessage attribute #1744

edwardhorsford opened this issue Feb 19, 2020 · 0 comments · Fixed by #1748
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@edwardhorsford
Copy link
Contributor

Talking with @hannalaakso yesterday, we realised the design system docs could be clearer that a false or null errorMessage would be ignored.

My team had interpreted the docs that if the errorMessage attribute were provided, macros would output error styling. It's easier for us to provide a false / null errorMessage attribute than it is to conditionally provide the whole thing.

Related: it would possibly be good to extend this behaviour to empty strings for errorMessage, which might match recent work where empty arrays were ignored.

@kellylee-gds kellylee-gds transferred this issue from alphagov/govuk-design-system Feb 24, 2020
@kellylee-gds kellylee-gds added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants