Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file copying tasks to remove Gulp #2711

Closed
6 tasks done
domoscargin opened this issue Jul 20, 2022 · 1 comment · Fixed by #3456
Closed
6 tasks done

Refactor file copying tasks to remove Gulp #2711

domoscargin opened this issue Jul 20, 2022 · 1 comment · Fixed by #3456
Labels
tooling

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Jul 20, 2022 •
edited by colinrotherham
Loading

What

Update tasks/gulp/copy-to-destination.js to replace Gulp with our own file copying script. There are currently two tasks in this file, one for copying source files to a destination, and one for copying the ESM source files to a destination.

Why

We have made the decision to move away from Gulp and write our own build scripts.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • tasks/gulp/copy-to-destination.js no longer depends on Gulp
  • heroku and test npm scripts no longer rely on taskArguments.destination
  • file copying tasks no longer rely on taskArguments.destination
  • docs/contributing/tasks.md has been updated
  • All dependencies are as up to date as is feasible
  • copy-to-destination.js has been relocated to tasks/copy-to-destination.js (or similar)
@domoscargin domoscargin added awaiting triage Needs triaging by team 🕔 days tooling and removed awaiting triage Needs triaging by team labels Jul 20, 2022
@domoscargin domoscargin mentioned this issue Jul 20, 2022
Closed
@kellylee-gds kellylee-gds added this to the Remove or improve Gulp milestone Jan 31, 2023
@kellylee-gds kellylee-gds removed this from the Remove or improve Gulp milestone Feb 2, 2023
@colinrotherham colinrotherham mentioned this issue Mar 9, 2023
Merged
@colinrotherham colinrotherham moved this from Backlog 🗄 to In progress 📝 in GOV.UK Design System cycle board Mar 9, 2023
@colinrotherham colinrotherham mentioned this issue Mar 9, 2023
Merged
@colinrotherham
Copy link
Contributor

colinrotherham commented Mar 30, 2023 •
edited
Loading

Accidentally completed via 8edda31, 2051717 as part of the --destination removal in:

@colinrotherham colinrotherham mentioned this issue Mar 30, 2023
Merged
@colinrotherham colinrotherham linked a pull request Mar 30, 2023 that will close this issue
Refactor file copying tasks to remove Gulp #3456
Merged
@colinrotherham colinrotherham moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Mar 31, 2023
@domoscargin domoscargin moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board Apr 11, 2023
@colinrotherham colinrotherham removed their assignment Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor file copying tasks to remove Gulp alphagov/govuk-frontend
3 participants
@colinrotherham @domoscargin @kellylee-gds