Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on gulp in heroku NPM script #2768

Closed
1 task
domoscargin opened this issue Aug 15, 2022 · 2 comments
Closed
1 task

Remove dependency on gulp in heroku NPM script #2768

domoscargin opened this issue Aug 15, 2022 · 2 comments
Labels

Comments

@domoscargin
Copy link
Contributor

What

Create a heroku.js script which handles at least the gulp copy-assets && gulp sassdoc portion of the heroku script in package.json.

Why

We have made the decision to move away from Gulp and write our own build scripts.

The heroku NPM script calls tasks through Gulp, which breaks when these tasks are updated to remove Gulp (eg: #2767).

We should ensure our NPM scripts have no gulp dependencies.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Gulp dependency in the heroku NPM script has been abstracted into a separate JS file, or removed entirely
@domoscargin
Copy link
Contributor Author

Moving this back to the backlog, as its dependent on updating the compilation tasks.

@domoscargin domoscargin removed their assignment Aug 16, 2022
@kellylee-gds kellylee-gds added this to the Remove or improve Gulp milestone Jan 31, 2023
@kellylee-gds kellylee-gds removed this from the Remove or improve Gulp milestone Feb 2, 2023
@domoscargin
Copy link
Contributor Author

Going to close this in favour of #2717

Think we need a discussion on the current state of this to prioritise future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants