Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new class for early styling #3507

Closed
1 task done
Tracked by #2639
romaricpascal opened this issue Apr 14, 2023 · 0 comments · Fixed by #3801
Closed
1 task done
Tracked by #2639

Implement new class for early styling #3507

romaricpascal opened this issue Apr 14, 2023 · 0 comments · Fixed by #3801
Labels
sass / css
Milestone
v5.0

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Apr 14, 2023 •
edited by colinrotherham
Loading

What

Update the CSS rules styling components when JavaScript is available to hook on the new govuk-frontend-supported class rather than js-enabled

Why

We're introducing a new class to mark where GOV.UK Frontend JavaScript components are supported, separating the concept JavaScript being available. We need to update the components styles to use that new class rather than the current one.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

Tasks
Beta Give feedback
@romaricpascal romaricpascal mentioned this issue Apr 14, 2023
Closed
@romaricpascal romaricpascal added this to the v5.0 milestone Apr 14, 2023
@colinrotherham colinrotherham moved this from Backlog 🗄 to Needs review 🔍 in GOV.UK Design System cycle board Jun 12, 2023
@colinrotherham colinrotherham mentioned this issue Jun 12, 2023
Merged
@colinrotherham colinrotherham linked a pull request Jun 12, 2023 that will close this issue
Add class .govuk-frontend-supported for ES modules support #3801
Merged
@colinrotherham colinrotherham moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sass / css
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Add class .govuk-frontend-supported for ES modules support alphagov/govuk-frontend
1 participant
@romaricpascal