Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of small variants of radios and checkboxes #3898

Closed
Tracked by #2289
owenatgov opened this issue Jul 3, 2023 · 2 comments · Fixed by #4093
Closed
Tracked by #2289

Fix alignment of small variants of radios and checkboxes #3898

owenatgov opened this issue Jul 3, 2023 · 2 comments · Fixed by #4093

Comments

@owenatgov
Copy link
Contributor

What

Re-work the small variants or the radio and checkbox components to be better aligned with their options and not use "magic numbers" to define alignment.

Why

During testing of the govuk-frontend components against the new typography scale, we noticed that both radio and checkbox small variants are now much more visibly misaligned from their labels. Because these variants are using "magic numbers" aka specific, non-dynamic numbers to define alignment, we think there's an opportunity to future proof this implementation, therefore fixing the issue found in the typography manual testing.

Who needs to work on this

Developers

Who needs to review this

Developers, designers

@owenatgov
Copy link
Contributor Author

Giving devs until Friday morning (11th Aug) to review the spike in its present state then will start writing production code.

@owenatgov owenatgov moved this from Needs review 🔍 to In progress 📝 in GOV.UK Design System cycle board Aug 14, 2023
@owenatgov owenatgov moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Aug 16, 2023
@owenatgov
Copy link
Contributor Author

Moving this into blocked until 5.0 is out. At which point we'll bundle this with a few changes around refactoring to anticipate the new type scale.

@owenatgov owenatgov moved this from Needs review 🔍 to Blocked ⛔ in GOV.UK Design System cycle board Aug 23, 2023
@kellylee-gds kellylee-gds moved this from Blocked ⛔ to Backlog 🗄 in GOV.UK Design System cycle board Sep 11, 2023
@owenatgov owenatgov modified the milestones: v5.x-candidate, v5.1 Oct 12, 2023
@owenatgov owenatgov moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Dec 15, 2023
@owenatgov owenatgov moved this from Sprint Backlog 🏃🏼‍♀️ to Needs review 🔍 in GOV.UK Design System cycle board Dec 18, 2023
@owenatgov owenatgov moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board Jan 10, 2024
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant