Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide which attributes to copy from the <input> to the <button> #5617

Closed
2 tasks
Tracked by #5626
romaricpascal opened this issue Jan 10, 2025 · 1 comment
Closed
2 tasks
Tracked by #5626
Assignees

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Jan 10, 2025

What

Decide which of the attributes of the <input> field need copying or move to the <button>.

Why

Some attributes like aria-describedby carry information for assistive technologies or may be used for other purposes. We need to decide which of these we'd want to copy/move to the button.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We have a list of attributes that should be copied to the button when the field is enhanced

and/or

  • We have an API to make this list configurable
@romaricpascal romaricpascal transferred this issue from alphagov/govuk-design-system Jan 16, 2025
@romaricpascal romaricpascal self-assigned this Jan 17, 2025
@romaricpascal romaricpascal moved this from Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Jan 17, 2025
@romaricpascal
Copy link
Member Author

We'll only copy aria-describedby used to associate the hints and errors, and the id to allow proper linking from the Error Summary. Other attributes can be copied by the service code once the component is initialised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant