Remove 'base' import from files in core and overrides layers
#2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing files from this layer without first importing the 'base' file was deprecated in #1807. Anyone who was relying on the import should already be seeing warnings. If this change affects them, they'll just need to ensure they're importing the base layer first. This is part of a change to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, designed to reduce the time it takes to compile the Sass to CSS. Remove the tests, which were only checking that the deprecation warning was emitted as expected.
Importing files from this layer without first importing the 'base' file was deprecated in #1807. Anyone who was relying on the import should already be seeing warnings. If this change affects them, they'll just need to ensure they're importing the base layer first. This is part of a change to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, designed to reduce the time it takes to compile the Sass to CSS. Remove the tests, which were only checking that the deprecation warning was emitted as expected.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2455
|
Still needs a changelog entry. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2455
vanitabarrett
approved these changes
Dec 3, 2021
|
Happy for this to be merged if @EoinShaughnessy is happy with the release notes. |
EoinShaughnessy
changed the title
core and overrides layers
vanitabarrett
force-pushed
the
remove-base-imports
branch
from
a85ea75 to
677c9ac
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2455
vanitabarrett
force-pushed
the
remove-base-imports
branch
from
677c9ac to
5050b3f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2455
EoinShaughnessy
approved these changes
Dec 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing files from these layers without first importing the 'base' file was deprecated in #1807. Anyone who was relying on these imports should already be seeing warnings. If this change affects them, they'll just need to ensure they're importing the base layer first.
This is part of a change to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, designed to reduce the time it takes to compile the Sass to CSS.
We can also remove the tests from both layers, which were only checking that the deprecation warning was emitted as expected.
Closes #1800.