Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file copying tasks to remove Gulp #3456

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Refactor file copying tasks to remove Gulp #3456

merged 3 commits into from
Apr 11, 2023

Conversation

colinrotherham
Copy link
Contributor

This PR removes Gulp from the generateFixtures() generateMacroOptions() tasks to complete:

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 March 30, 2023 18:53 Inactive
@colinrotherham colinrotherham linked an issue Mar 30, 2023 that may be closed by this pull request
6 tasks
@colinrotherham colinrotherham force-pushed the build-tasks-gulpfile-app branch from a47ebdb to 3891d17 Compare March 30, 2023 19:00
@colinrotherham colinrotherham requested a review from a team as a code owner March 30, 2023 19:00
@colinrotherham colinrotherham force-pushed the build-tasks-gulpfile-app branch 2 times, most recently from 7887cab to 69b3f08 Compare March 30, 2023 19:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 March 30, 2023 19:09 Inactive
Base automatically changed from build-tasks-gulpfile-app to main March 30, 2023 19:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 March 31, 2023 08:50 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 April 3, 2023 08:55 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 April 3, 2023 14:19 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 April 3, 2023 15:00 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 April 3, 2023 20:24 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3456 April 11, 2023 11:00 Inactive
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The only diff in the outputted JSON files is that they don't have EOLs now. The version file in dist is exactly the same, and I like that we've dropped a few dependencies.

Nice stuff.

Did some unscientific bulk testing of npm run build:package and there's nothing in it for speed.

I don't think the resulting code is much lengthier or less understandable compared to the gulp-based approach.

tasks/configs.mjs Show resolved Hide resolved
package.json Show resolved Hide resolved
@colinrotherham
Copy link
Contributor Author

The only diff in the outputted JSON files is that they don't have EOLs now. The version file in dist is exactly the same, and I like that we've dropped a few dependencies.

Thanks @domoscargin

Can you double check your diff direction? After this PR merges we should see trailing newline characters (as a consistency improvement) in fixtures.json and macro-options.json where they were missed previously

Although to reduce the diff size I've kept the 4-space indent (rather than our 2-space default)

@domoscargin
Copy link
Contributor

Can you double check your diff direction?

🤦 I doublechecked this before commenting and still somehow got it the wrong way round!

@colinrotherham
Copy link
Contributor Author

@domoscargin Don't worry, it caught me out when I wrote it! Cheers

@colinrotherham colinrotherham merged commit c628dd1 into main Apr 11, 2023
@colinrotherham colinrotherham deleted the ungulp-json branch April 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor file copying tasks to remove Gulp
3 participants