Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GOVUKFrontend prefix from GOVUKFrontendComponent #5515

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove GOVUKFrontend prefix from GOVUKFrontendComponent #5515

wants to merge 4 commits into from

Commits on Nov 22, 2024

  1. Remove GOVUKFrontend prefix from Component 

    - `GOVUKFrontendComponent` is now `Component`. Renamed
`govuk-frontend-component.mjs` to `component.mjs` and the associated
test. Changed references to `GOVUKFrontendComponent` to `Component` in
the test.
- Created new `govuk-frontend-component.mjs` that imports `Component`
and exports it as `GOVUKFrontendComponent` to avoid a breaking change.
    @patrickpatrickpatrick
    patrickpatrickpatrick committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    67890f0 View commit details
    Browse the repository at this point in the history

  2. Update components to import Component 

    Components that extended `GOVUKFrontendComponent` now extend `Component`
from `component.mjs`.
    @patrickpatrickpatrick
    patrickpatrickpatrick committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b3454c6 View commit details
    Browse the repository at this point in the history

  3. Update ConfigurableComponent to use Component

    @patrickpatrickpatrick
    patrickpatrickpatrick committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3b9ace6 View commit details
    Browse the repository at this point in the history

  4. Add deprecated JavaScript files to package build 

    Because they're not imported by `all.mjs` deprecated JavaScript files were not included in the package (in which they need to remain until the next breaking release).

This adds a module to store the list of deprecated JavaScript files and helper functions that are then used:
- in the Gulp configuration, to add a new task building each deprecated file individually
- in the Rollup configuration, to prevent the bundled output of the deprecated files as all we want is for them to be in the package as a module

Co-authored-by: Patrick Cartlidge <patrick.cartlidge@digital.cabinet-office.gov.uk>
Co-authored-by: Brett Kyle <brett.kyle@digital.cabinet-office.gov.uk>
    @romaricpascal @patrickpatrickpatrick @domoscargin
    3 people committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    95eb0d4 View commit details
    Browse the repository at this point in the history