Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow type="module" on Plug-In scripts #2078

Closed
2 tasks
nataliecarey opened this issue Apr 3, 2023 · 0 comments · Fixed by #2088
Closed
2 tasks

Allow type="module" on Plug-In scripts #2078

nataliecarey opened this issue Apr 3, 2023 · 0 comments · Fixed by #2088
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve.

Comments

@nataliecarey
Copy link
Contributor

What

v5 of the Design System will likely require a type="module" attribute on the <script> tag (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules)

We need to support that in the kit

Why

So that anyone who wants to use type="module" in their Plug-In can use it.

Who needs to work on this

  • Developer

Who needs to review this

  • Developer

Done when

  • A Plug-In author can specify they want type="module"
  • By default we don't use type="module" for Plug-In scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plugin authors can now use scripts with type module alphagov/govuk-prototype-kit
2 participants
@nataliecarey @ruthhammond