Unbranded template in examples does not include updated bodyEnd block

[daviddotto]

Scripts do not run on unbranded pages due to bodyEnd block having not been updated to camel case.

{% block body_end %}
  {% include "includes/scripts.html" %}
{% endblock %}

should be

{% block bodyEnd %}
  {% include "includes/scripts.html" %}
{% endblock %}

Also, is there a particular reason the unbranded template is not in the app/views directory by default? There also are no macro imports in this file, might be work keeping it in line with the template.html file.

[36degrees]

Hey David,

Thanks for raising! Would you be willing to raise a pull request to fix the body end block issue?

I'll chat to the team about the other two issues you mention and try and understand the reasoning.

Thanks,

Ollie

[daviddotto]

Happy to, I don't have the relevant permissions to push my branch though, perhaps I need added to the team?

[36degrees]

We'd normally expect people to contribute to the Prototype Kit by making the changes on a fork of the repo – GitHub's documentation on this is pretty good at walking you through that.

Let me know if I can help at all.

[daviddotto]

Cheers, I thought I might be doing something wrong. Will do.

…

On 14 Aug 2018, at 13:59, Oliver Byford ***@***.***> wrote: We'd normally expect people to contribute to the Prototype Kit by making the changes on a fork of the repo – GitHub's documentation on this is pretty good at walking you through that. Let me know if I can help at all. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[daviddotto]

#580 added

[daviddotto]

Template updated now