Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the unbranded layout inside docs available for use in app/views #602

Closed
adamsilver opened this issue Sep 27, 2018 · 4 comments
Closed
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@adamsilver
Copy link

adamsilver commented Sep 27, 2018

I have a page in app/views that would ideally use layout_unbranded.html which currently lives in docs.

The reason for this is to simulate the user receiving/viewing an email before accessing a service. I could recreate the layout for myself in app/views but for now I am referencing {% extends "govuk_template_unbranded.html" %} which looks like this:

image

I'd like some basic styling and the ability to turn off the skip link if that's possible.

@joelanman
Copy link
Contributor

Hi Adam, have you tried extending from layout_unbranded as in the template here:

https://github.com/alphagov/govuk-prototype-kit/blob/master/docs/views/templates/blank-unbranded.html

@adamsilver
Copy link
Author

adamsilver commented Oct 3, 2018

That's the thing—I can't seem to do that. When I do I get this:

Error: template not found: create-user-account.html
Template render error: (/Users/adambsilver/work/hmcts/pui-prototype/app/views/create-user-account/index.html) Error: template not found: layout_unbranded.html

@joelanman
Copy link
Contributor

Sorry yeh this seems broken, and has been for a while :/ we'll look into it

@joelanman joelanman added the 🐛 Bug Something isn't working the way it should (including incorrect wording in documentation) label Oct 3, 2018
@kr8n3r
Copy link

kr8n3r commented Oct 3, 2018

we can do this two ways:
a) move the unbranded layout into app/
b) point to that view in appViews variable in server.js so that it can be extended from the app/ folder file while still physically being in docs/ folder

I vote for a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

3 participants