Add tests for download #1368
Closed
Add tests for download #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
7d9e919 to
ca200e8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
41b180c to
ca200e8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
e863894 to
ca200e8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
68efe6d to
bc70bed
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
bc70bed to
9dbc67d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
9dbc67d to
33e97a9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-create-tut-gupurg
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
4 times, most recently
from
5627fda to
b399ef4
Compare
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
5 times, most recently
from
c034544 to
8a24d80
Compare
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
3 times, most recently
from
91ee3f0 to
60311eb
Compare
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
2 times, most recently
from
86bd033 to
70bcb6e
Compare
|
I'm worried about this test, for a couple of reasons:
Is there any way to mitigate these issues? |
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
4 times, most recently
from
0823576 to
fdc3b86
Compare
I have to admit these are all valid points. I guess the original intention was to attempt to download and install the kit from a zipped file but as we are doing something similar I changed it to just check that the link to download the latest version of the kit as a zip file does indeed download the latest version of the code. |
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
9 times, most recently
from
e6ed952 to
55d98cc
Compare
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
3 times, most recently
from
76bd988 to
faffd4d
Compare
BenSurgisonGDS
force-pushed
the
create-tutorial
branch
from
faffd4d to
0acda98
Compare
lfdebrux
reviewed
Aug 12, 2022
Comment on lines
+12
to
+16
| strategy: | ||
| fail-fast: false # continue other tests if one test in matrix fails | ||
| matrix: | ||
| node-version: [12.x, 14.x, 16.x] | ||
| os: [macos-latest, windows-latest, ubuntu-latest] |
There was a problem hiding this comment.
We probably don't need to test this across the whole matrix, I think running it just on ubuntu and the latest version of Node should be fine.
Comment on lines
+47
to
+59
| - run: npm run test:download | ||
| env: | ||
| CYPRESS_REQUEST_TIMEOUT: 20000 | ||
| CYPRESS_DEFAULT_COMMAND_TIMEOUT: 40000 | ||
| CYPRESS_PAGE_LOAD_TIMEOUT: 150000 | ||
| CYPRESS_RETRIES: 3 | ||
|
|
||
| - run: npm run test:download:package | ||
| env: | ||
| CYPRESS_REQUEST_TIMEOUT: 20000 | ||
| CYPRESS_DEFAULT_COMMAND_TIMEOUT: 40000 | ||
| CYPRESS_PAGE_LOAD_TIMEOUT: 150000 | ||
| CYPRESS_RETRIES: 3 |
There was a problem hiding this comment.
Let's run this just once, as a package
Suggested change
| - run: npm run test:download | |
| env: | |
| CYPRESS_REQUEST_TIMEOUT: 20000 | |
| CYPRESS_DEFAULT_COMMAND_TIMEOUT: 40000 | |
| CYPRESS_PAGE_LOAD_TIMEOUT: 150000 | |
| CYPRESS_RETRIES: 3 | |
| - run: npm run test:download:package | |
| env: | |
| CYPRESS_REQUEST_TIMEOUT: 20000 | |
| CYPRESS_DEFAULT_COMMAND_TIMEOUT: 40000 | |
| CYPRESS_PAGE_LOAD_TIMEOUT: 150000 | |
| CYPRESS_RETRIES: 3 | |
| - run: npm run test:download:package | |
| env: | |
| CYPRESS_REQUEST_TIMEOUT: 20000 | |
| CYPRESS_DEFAULT_COMMAND_TIMEOUT: 40000 | |
| CYPRESS_PAGE_LOAD_TIMEOUT: 150000 | |
| CYPRESS_RETRIES: 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to download and extract the latest zip file of the prototype kit.
Please note that as cypress has an issue testing a download from an external page, I have created a custom cypress command to retrieve the href of the download and then download the file manually.
Note also that the download test runs in a seperate action.