Cypress test for service name #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
BenSurgisonGDS
force-pushed
the
integration-test-for-service-name
branch
from
27e5e0b to
1cdcf79
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
BenSurgisonGDS
force-pushed
the
integration-test-for-service-name
branch
from
8b18a63 to
2015034
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
lfdebrux
reviewed
Jul 5, 2022
cypress/plugins/index.js
Outdated
Comment on lines
95
to
92
| try { | ||
| const content = fs.readFileSync(filename).toString() | ||
| fs.writeFileSync(filename, content.replace(originalText, newText)) | ||
| return Promise.resolve(null) | ||
| } catch (err) { | ||
| return Promise.reject(err) | ||
| } |
There was a problem hiding this comment.
If we're writing an async function is there any reason not to use the fs.promises methods?
There was a problem hiding this comment.
I have changed this to use fs.promises but had to still return Promise.resolve(null) so that cypress was happy.
There was a problem hiding this comment.
Changing this back to draft while I wait for the PR to use fs.promises is merged into main. I'll then rebase this on to main and amend this test to match.
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
BenSurgisonGDS
force-pushed
the
integration-test-for-service-name
branch
from
30e26f8 to
382ce38
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
BenSurgisonGDS
force-pushed
the
integration-test-for-service-name
branch
from
750e072 to
83795b7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
nataliecarey
reviewed
Jul 6, 2022
cypress/plugins/index.js
Outdated
| @@ -50,6 +51,8 @@ module.exports = (on, config) => { | |||
|
|
|||
| const waitUntilAppRestarts = async (timeout) => await waitOn({ delay: 2000, resources: [config.baseUrl], timeout }) | |||
|
|
|||
| const makeSureCypressCanInterpretTheResult = () => null | |||
There was a problem hiding this comment.
As I commented here https://github.com/alphagov/govuk-prototype-kit/pull/1454/files#r915009116
I think it's worth passing through any non-undefined result unless you're sure it makes no difference.
Also, should this function be centralised in test helpers somewhere?
If I'm overcomplicating it I'm happy with it as-is and we can update if it causes a problem.
nataliecarey
approved these changes
Jul 6, 2022
BenSurgisonGDS
force-pushed
the
integration-test-for-service-name
branch
from
83795b7 to
b9a6b95
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
BenSurgisonGDS
force-pushed
the
integration-test-for-service-name
branch
from
39a81ce to
20e06e1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-protot-integratio-09yuyg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress test to detect the service name change in the app config