Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create govuk-branded.html template #1522

Closed
2 tasks done
lfdebrux opened this issue Aug 11, 2022 · 0 comments · Fixed by #1549
Closed
2 tasks done

Create govuk-branded.html template #1522

lfdebrux opened this issue Aug 11, 2022 · 0 comments · Fixed by #1549
Assignees

Comments

@lfdebrux
Copy link
Member

lfdebrux commented Aug 11, 2022

What

Create lib/nunjucks/govuk-prototype-kit/layouts/govuk-branded.html, which contains contents of current app/views/layout.html.

app/views/layout.html can contain just a single line extending new layout. We may want more in there in the future but that is out of scope for this ticket.

Make sure that govuk-branded.html includes includes/stylesheets.html and includes/scripts.html, and has stylesheets, scripts, pageScripts and other convenience blocks for users.

Why

We want to move common lines in layout.html into the kit so we have more control over it and users have less to worry about when updating.

Who needs to work on this

Developer

Who needs to review this

Developer

Done when

  • layout.html is almost empty
  • Kit works as a package with all styles and macros as before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants