Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate changed files if possible #2049

Merged
merged 22 commits into from
Apr 5, 2023
Merged

Migrate changed files if possible #2049

merged 22 commits into from
Apr 5, 2023

Commits on Apr 3, 2023

  1. Migrate changed files if possible

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f7d82c2 View commit details
    Browse the repository at this point in the history

  2. adding test for upgradeIfPossible method

    @HannahJMWood @BenSurgisonGDS
    HannahJMWood authored and BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    66c836d View commit details
    Browse the repository at this point in the history

  3. refactoring application update into its own method

    @HannahJMWood @BenSurgisonGDS
    HannahJMWood authored and BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    58e6336 View commit details
    Browse the repository at this point in the history

  4. started fixing issues with failing test

    @HannahJMWood @BenSurgisonGDS
    HannahJMWood authored and BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b783ffb View commit details
    Browse the repository at this point in the history

  5. Replace any of the sections if possible

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c68628a View commit details
    Browse the repository at this point in the history

  6. add globals line if there's jquery in application

    @HannahJMWood @BenSurgisonGDS
    HannahJMWood authored and BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d4816f9 View commit details
    Browse the repository at this point in the history

  7. adding another new line and comment

    @HannahJMWood @BenSurgisonGDS
    HannahJMWood authored and BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    fe19a65 View commit details
    Browse the repository at this point in the history

  8. Make sure all original lines exist in sequence within the file before… 

    … replacing them
    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    7c41308 View commit details
    Browse the repository at this point in the history

  9. addressing some review comments

    @HannahJMWood @BenSurgisonGDS
    HannahJMWood authored and BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2cb2652 View commit details
    Browse the repository at this point in the history

  10. Just insert user's code into starter application code

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6a0618e View commit details
    Browse the repository at this point in the history

  11. Fix verbose log

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    abfa486 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Simplify

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    67fafe5 View commit details
    Browse the repository at this point in the history

  2. Add change log entry

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c442ed0 View commit details
    Browse the repository at this point in the history

  3. Migrate changed filters if possible

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9db7e7a View commit details
    Browse the repository at this point in the history

  4. Fixed tests

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3c9b1f9 View commit details
    Browse the repository at this point in the history

  5. Add change log entry

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e70e3cb View commit details
    Browse the repository at this point in the history

  6. Fix application.js conversion

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    59764d4 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #2079 from alphagov/migrate-changed-filters-if-pos… 

    …sible

Migrate changed filters if possible
    @BenSurgisonGDS
    BenSurgisonGDS authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c6a064c View commit details
    Browse the repository at this point in the history

  8. Add more complex application.js to test

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    40f2d4e View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Add line containing the frontend initAll function to make sure it is … 

    …removed
    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e0518bc View commit details
    Browse the repository at this point in the history

  2. Remove big comment if unchanged from filters file and move upgrade fu… 

    …nctions to new upgrade-steps.js
    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6a2f813 View commit details
    Browse the repository at this point in the history

  3. Fix test

    @BenSurgisonGDS
    BenSurgisonGDS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    46e3a5f View commit details
    Browse the repository at this point in the history