Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prototype Kit README and CONTRIBUTING with support details #2390

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

kellylee-gds
Copy link
Contributor

No description provided.

@colinrotherham
Copy link
Contributor

Blocked by #2327

There are a few tests that break because they're not updated (yet) to GOV.UK Frontend v5

@colinrotherham
Copy link
Contributor

@kellylee-gds I've rebased this PR with the updates in #2327 so everything should pass now

Couple of tests can be a bit flaky but they'll work once re-run

@kellylee-gds
Copy link
Contributor Author

Thanks @colinrotherham

@kellylee-gds kellylee-gds changed the title Update Prototype Kit README with support details Update Prototype Kit README and CONTRIBUTING with support details Jan 11, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
@stevenjmesser
Copy link

Does this still need a review?

Copy link

@stevenjmesser stevenjmesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Someone on cross-government Slack did suggest that departments might want to offer their time to support and maintain this, but I think those notes can be added to the issues rather than these files.

@kellylee-gds kellylee-gds self-assigned this Jan 18, 2024
README.md Outdated
@@ -27,11 +27,9 @@ The Prototype Kit always supports at least the current and previous LTS releases

## Support

The GOV.UK Prototype Kit is maintained by the Government Digital Service. If you’ve got a question or need support you can:
The GOV.UK Prototype Kit is currently maintained by the [GOV.UK Design System team](https://design-system.service.gov.uk/get-in-touch/). There is only [minimal support in place](https://github.com/alphagov/govuk-prototype-kit/issues/2389) as the current version is stable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure we changed this wording elsewhere – I'm hesitant to suggest that because the kit is stable we only 'need' to provide minimal support.

I think it's better to just say something like 'we can only provide minimal support at this time'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Changed it 👍🏻

@36degrees 36degrees force-pushed the kellylee-gds-patch-2 branch from c9e57a1 to c6d3a67 Compare January 22, 2024 14:00
@36degrees
Copy link
Contributor

I've force pushed to tidy up the commit history. I also updated the link to the Slack channel in the README to be a Markdown link and to include more link text for better context.

@kellylee-gds kellylee-gds merged commit 73e4b7d into main Jan 22, 2024
30 checks passed
@kellylee-gds kellylee-gds deleted the kellylee-gds-patch-2 branch January 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants