-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prototype Kit README and CONTRIBUTING with support details #2390
Conversation
Blocked by #2327 There are a few tests that break because they're not updated (yet) to GOV.UK Frontend v5 |
4dca2c3
to
51c17e9
Compare
@kellylee-gds I've rebased this PR with the updates in #2327 so everything should pass now Couple of tests can be a bit flaky but they'll work once re-run |
Thanks @colinrotherham |
Does this still need a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Someone on cross-government Slack did suggest that departments might want to offer their time to support and maintain this, but I think those notes can be added to the issues rather than these files.
README.md
Outdated
@@ -27,11 +27,9 @@ The Prototype Kit always supports at least the current and previous LTS releases | |||
|
|||
## Support | |||
|
|||
The GOV.UK Prototype Kit is maintained by the Government Digital Service. If you’ve got a question or need support you can: | |||
The GOV.UK Prototype Kit is currently maintained by the [GOV.UK Design System team](https://design-system.service.gov.uk/get-in-touch/). There is only [minimal support in place](https://github.com/alphagov/govuk-prototype-kit/issues/2389) as the current version is stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure we changed this wording elsewhere – I'm hesitant to suggest that because the kit is stable we only 'need' to provide minimal support.
I think it's better to just say something like 'we can only provide minimal support at this time'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot! Changed it 👍🏻
c9e57a1
to
c6d3a67
Compare
I've force pushed to tidy up the commit history. I also updated the link to the Slack channel in the README to be a Markdown link and to include more link text for better context. |
No description provided.