Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for mandatory primary publishing organisation #92

Closed
wants to merge 1 commit into from

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Jun 18, 2018

Rendered markdown

TLDR:

Data on content ownership is patchy. We are gradually adding it to the publishing API. We should make sure that new content always has this metadata set.

If this metadata is not enforced, we can expect data quality to degrade over time as we make changes to publishing apps/content types and forget to set stuff. Incomplete ownership data would affect future work on content management.

Closing Monday 25th June.

@MatMoore MatMoore changed the title RFC for manadatory primary publishing organisation RFC for mandatory primary publishing organisation Jun 18, 2018
@kevindew
Copy link
Member

I think we have a challenge on how to make this mandatory at Publishing API level with schemas

It can be mandatory if it's part of the PutContent endpoint as a required link - but with PatchLinkSet (I'm assuming your planning to use that based on the slack conversation following this) you can't make any links required as in it's patch nature it expects to be able to just change a couple and not the whole set.

@MatMoore
Copy link
Contributor Author

Ah, good point, damn.

Maybe we should make it part of put content then. Can you think of any drawbacks to this approach? Unfortunately we've just gone an added it to a bunch of apps using the patch links method. ☹️

@kevindew
Copy link
Member

Only drawback with PutContent if I remember correctly is that they don't support child links / hierarchies.

With any mandatory link you always have the problem that it only exists if the document to link it to exists, there are no ways to ensure a link will definitely exist unfortunately.

@MatMoore
Copy link
Contributor Author

I think that's fine, since the link only makes sense if the document exists.

But the downside of this is if there are machinery of government changes, then this data would need to be updated, even though the content itself hasn't changed.

And unfortunately we've also already added a bunch of code to publishing applications that uses the patch links method. 🤔

@cbaines
Copy link
Contributor

cbaines commented Jun 18, 2018

Only drawback with PutContent if I remember correctly is that they don't support child links / hierarchies.

... and possibly that changing the link requires publishing a new edition of the document.

@MatMoore
Copy link
Contributor Author

Yeah, this is part of the reason we stuck with patch links when we started this work.

It seems wrong that changing metadata about a document changes the history of the document itself.

@MatMoore
Copy link
Contributor Author

I'm going to reject this RFC in its current form, as I overlooked the 'patch' nature of these links, which is incompatible with making them mandatory at publish time. I'm not convinced that edition links are a perfect fit either, so I'm not going to amend the proposal now.

I still think this thing should be mandatory, but I don't have a simple solution that I can make happen this quarter. Next quarter I'm not going to be on GOV.UK, so if we do continue with this idea, someone else will need to take it over. 🏃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants