Add cookies and privacy policy pages #502
Conversation
|
@dashouse The other pr / kit isn't linked. Can you add some details to this PR description about this change? |
CHANGELOG.md
Outdated
| @@ -7,7 +7,7 @@ Bug fixes: | |||
| # 6.3.0 | |||
|
|
|||
| New features: | |||
|
|
|||
| - [#502 Add Cookies and Privacy policy text](https://github.com/alphagov/govuk_prototype_kit/pull/502) | |||
There was a problem hiding this comment.
This should probably be listed above 6.3, under an 'Unreleased' heading.
docs/views/layout.html
Outdated
| </li> | ||
| </ul> | ||
| {% endif %} | ||
| <ul class="govuk-!-mb-r3 app-!-db"> |
There was a problem hiding this comment.
This looks like a govuk-frontend class - will this work in the kit as it stands?
dashouse
force-pushed
the
add-cookies-and-privacy-policy
branch
from
34c9406
to
caee658
Compare
|
@edwardhorsford Thanks for spotting Ed, updated. |
CHANGELOG.md
Outdated
| @@ -4,10 +4,12 @@ Bug fixes: | |||
|
|
|||
| - [#491 Remove redundant Google Analytics](https://github.com/alphagov/govuk_prototype_kit/pull/491) | |||
|
|
|||
| Unreleased: | |||
There was a problem hiding this comment.
Sorry, just spotted there's already an unreleased heading. Do you consider this a new feature?
There was a problem hiding this comment.
I guess this is a drawback of having the kit and the site be the same thing. I think in the past we've called new things on the site 'features' so this is consistent.
CHANGELOG.md
Outdated
| @@ -4,10 +4,12 @@ Bug fixes: | |||
|
|
|||
| - [#491 Remove redundant Google Analytics](https://github.com/alphagov/govuk_prototype_kit/pull/491) | |||
|
|
|||
| Unreleased: | |||
| - [#502 Add Cookies and Privacy policy text](https://github.com/alphagov/govuk_prototype_kit/pull/502) | |||
There was a problem hiding this comment.
Do you think this (or perhaps the PR?) should explicitly state that this is for the Kit site (promo mode) rather than the kit in general?
There was a problem hiding this comment.
we don't normally do that (see the PR just above) - we could consider starting to add a [Site] tag or something in future but I don't think it should block this PR
dashouse
force-pushed
the
add-cookies-and-privacy-policy
branch
from
6b47417
to
a87497a
Compare
|
Updated changelog to add this as a "new feature" |
|
Thanks for these changes @dashouse. Would it be possible to squash the commits? Then I think it looks good to go. |
|
@dashouse you can ignore me. @joelanman points out that each of your commits make sense. Looks good to go 👍 |
|
Merged, thanks @edwardhorsford @joelanman |
This PR replicates the (already merged) Cookies and Privacy policy pages on the beta version of the prototype kit.
This change:
In addition there are some docs specific styles for
table: fixedand an override fordisplay: blockin order to style these pages in the same way as on the beta version of the kit and the design system.