Do not track users who have enabled 'DoNotTrack' #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a guard around Google Tag Manager script to prevent it from initialising, for users who have indicated they do not want to be tracked.
joelanman
suggested changes
Jun 27, 2018
| @@ -3,14 +3,13 @@ | |||
| New features: | |||
|
|
|||
| - [#501 Add default session data](https://github.com/alphagov/govuk_prototype_kit/pull/501) | |||
| - [#502 Add Cookies and Privacy policy text](https://github.com/alphagov/govuk_prototype_kit/pull/502) | |||
There was a problem hiding this comment.
this doesn't look like it belongs in this PR
There was a problem hiding this comment.
I'm cleaning up the fact there's two 'new features' sections in the unreleased section.
There was a problem hiding this comment.
oh right its moved not an addition, ok
joelanman
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a guard around Google Tag Manager script to prevent it from initialising,
for users who have indicated they do not want to be tracked.
Cherry picked from alphagov/govuk-prototype-kit-private-beta#52
Closes #518