Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import missing component macros #536

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Import missing component macros #536

merged 2 commits into from
Jul 12, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Jul 4, 2018

Fixes: #534

@joelanman
Copy link
Contributor

thanks!

One thing - this includes 'hint' which I think is just an 'internal' macro - we don't talk about it in the design system. There's already inconsistency in the kit because we load 'label' which is also 'internal'.

Not sure if we want include internal components in the kit, or exclude them.

@kr8n3r
Copy link
Author

kr8n3r commented Jul 4, 2018 •
edited
Loading

seems like no one looks at what is being imported, only what is missing. can just remove the hint as it's always going to be used in a component. label can be used on it's own

36degrees
36degrees approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kr8n3r kr8n3r force-pushed the import-all-macros branch 3 times, most recently from 6158648 to 3f13568 Compare July 10, 2018 14:27
Jani Kraner added 2 commits July 12, 2018 09:11
Update the list of imported macros
d16ff8f 
Import missing tabs and inset-text macros and remove
hint and label as they're internal to other components.
Document in CHANGELOG
cfdd105
@kr8n3r kr8n3r merged commit c65d240 into master Jul 12, 2018
@kr8n3r kr8n3r deleted the import-all-macros branch July 12, 2018 08:23
@joelanman joelanman mentioned this pull request Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kr8n3r @joelanman @36degrees