Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crown logo uses deprecated <image> tag #2309

Closed
injms opened this issue Sep 15, 2021 · 0 comments · Fixed by #2313
Closed

Crown logo uses deprecated <image> tag #2309

injms opened this issue Sep 15, 2021 · 0 comments · Fixed by #2313
Labels
code quality govuk-frontend Addresses misalignments with govuk-frontend

Comments

@injms
Copy link
Contributor

injms commented Sep 15, 2021

The crown logo uses an <image> element as a fallback for browsers that don't support SVGs - this was removed from GOV.UK Frontend in v3.13.0 (commit) and replaced with a conditional comment. The markup for the header components should be updated to match this approach.
@injms injms added code quality govuk-frontend Addresses misalignments with govuk-frontend labels Sep 15, 2021
@injms injms mentioned this issue Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality govuk-frontend Addresses misalignments with govuk-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update crown fallback image alphagov/govuk_publishing_components
1 participant
@injms