Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and cleanup dependencies #139

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Update and cleanup dependencies #139

merged 3 commits into from
Oct 8, 2021

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented Oct 8, 2021

What

  • regular dependency update
  • cleanup of unused dependencies
  • changes needed with updated dependencies

How to test

  • clone branch
  • install updated dependencies (npm install)
  • build the site (npm run build)
  • cd into out folder and serve the page (npx serve)
  • check page on localhost:5000 for any issues

There are expected warnings in CSS compilation coming from govuk-frontend

npm install will output 6 high severity vulnerabilities.
They're slowdowns and we cannot do anything about them for now. See hashicorp/next-mdx-remote#144

kr8n3r added 3 commits October 8, 2021 11:20
It's now a ES module package which is making next-mdx-remote a bit unhappy,
so we're supressing typescript type error on build as identified in hashicorp/next-mdx-remote#86
Copy link
Contributor

@schmie schmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendered pages look all good 👍

@kr8n3r kr8n3r merged commit 02a8614 into main Oct 8, 2021
@kr8n3r kr8n3r deleted the updates branch October 8, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants