From 976e316156ed2d9d783f351847229ea058091eaa Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Tue, 12 Nov 2019 17:49:16 +0000 Subject: [PATCH 1/3] Ensure the page can be pinch to zoomed I've tested in latest versions of iOS and Android. - iOS v10 onwards ignores disabling pinch to zoom - Android does not ignore disabling pinch to zoom, although the user can override this. I have not been able to introduce any negative impact for removing pinch to zoom, the interface scales proportionally and does not obstruct anything. So given that iOS already ignores this I think we should allow this for all users. This is also a WCAG accessibility requirement. Fixes https://github.com/alphagov/tech-docs-gem/issues/110 --- lib/source/layouts/core.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/source/layouts/core.erb b/lib/source/layouts/core.erb index 5be3b927..2237909b 100644 --- a/lib/source/layouts/core.erb +++ b/lib/source/layouts/core.erb @@ -3,7 +3,7 @@ - + <% if config[:tech_docs][:prevent_indexing] %> <% end %> From 1775345cb33420df002c8a302cc89d4f8e0dd69a Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Thu, 14 Nov 2019 11:19:57 +0000 Subject: [PATCH 2/3] Update CHANGELOG to match Design System style --- CHANGELOG.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 45b37c12..e8825e29 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,9 @@ ## Unreleased -Change how tables are laid out to fix some content in Notify tech' docs being squashed due to its -column having a fixed width. +### Fixes -Related issue: https://github.com/alphagov/tech-docs-gem/issues/133 +- [Pull request #154: Fix table columns breaking content](https://github.com/alphagov/tech-docs-gem/pull/154). ## 2.0.8 From 4abcc49720db97bad8b847ac04a3f84057a7a7f1 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Thu, 14 Nov 2019 11:22:10 +0000 Subject: [PATCH 3/3] Add CHANGELOG entry for pinch to zoom --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e8825e29..3537c143 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - [Pull request #154: Fix table columns breaking content](https://github.com/alphagov/tech-docs-gem/pull/154). +- [Pull request #155: Ensure the page can be pinch to zoomed](https://github.com/alphagov/tech-docs-gem/pull/155). ## 2.0.8