Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace resolver by typeless operator executer #40

Closed
nopeslide opened this issue Jul 10, 2020 · 0 comments · Fixed by #57
Closed

replace resolver by typeless operator executer #40

nopeslide opened this issue Jul 10, 2020 · 0 comments · Fixed by #57

Comments

@nopeslide
Copy link
Collaborator

nopeslide commented Jul 10, 2020

  • Not all operators have an input type constraint, let's call them unconstrained (see constant).
  • Unconstrained operators can't be resolved, since no type constraint exists to be resolved.
  • All operators have an unconstrained operator implementation (current status, no relation to this issue).
  • Constrained operators can't make use of this unconstrained operator implementation.
  • All resolvers are autogenerated, but the generated ones for unconstrained operators make no sense (maybe stop generating them?).
  • Instead of searching inside the set structure for a resolver, we could always return the unconstrained operator executer.
  • The unconstrained operator executer 'knows' if it's constrained and can call the resolver to find its type specific implementation or be itself the actual implementation.
  • If any custom implementation is needed, one can directly modify the unconstrained operator without touching autogenerated code or other type specific implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant