You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the resolve function stores the node_context in a global statically defined variable. See all_context and _populatedIdx in inference.c.
The main problem is that all_context is hardcoded arbitrarily to 50, which makes a model with more than 50 nodes to fail. This should be allocated dynamically to a n number of nodes.
On top of that, it would be better if the resolve function returns a pointer to a heap node_context, so different node_context can coexist in the same code.
Definition Of Done (DoD):
Remove all_context and _populatedIdx.
Return a struct from the resolve function. This struct contains the context of all nodes plus some kind of index to keep track of the ones that have been populated (the functionality that _populatedIdx had.
Integrate it with the existing code.
The text was updated successfully, but these errors were encountered:
Currently the
resolve
function stores thenode_context
in a global statically defined variable. Seeall_context
and_populatedIdx
ininference.c
.The main problem is that
all_context
is hardcoded arbitrarily to 50, which makes a model with more than 50 nodes to fail. This should be allocated dynamically to an
number of nodes.On top of that, it would be better if the
resolve
function returns a pointer to a heapnode_context
, so differentnode_context
can coexist in the same code.Definition Of Done (DoD):
all_context
and_populatedIdx
.resolve
function. This struct contains the context of all nodes plus some kind of index to keep track of the ones that have been populated (the functionality that_populatedIdx
had.The text was updated successfully, but these errors were encountered: