Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image zoom feature #177

Closed
alshedivat opened this issue Jan 8, 2021 · 1 comment
Closed

Add image zoom feature #177

alshedivat opened this issue Jan 8, 2021 · 1 comment

Comments

@alshedivat
Copy link
Owner

Image zooming (https://github.com/kingdido999/zooming/) could be particularly useful for project pages and blog posts.

@Jongwoo-Shim
Copy link
Contributor

Jongwoo-Shim commented Jan 19, 2021

@alshedivat I tried playing around with the zoom library that you provided, and I think that we'd be better off using a different one. When trying to integrate it with the existing dark-mode I encountered multiple bugs.

  • Issues with opacity when trying to use css-variables.
  • Not running until the mode toggle is first hit. This is despite the listener being initialized during the theming initialization.
  • Say hello to stretchy al :
    image
    • This happens when repeatedly zooming in/out the image.

I've been looking into medium-zoom instead. If that doesn't work either, then I think maybe just raw js might be the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants